Re: [PATCH] x86: punit_atom: punit device state debug driver

[Srinivas Pandruvada]

On Sat, 2015-04-25 at 11:43 +0200, Paul Bolle wrote:
> On Fri, 2015-04-24 at 14:42 -0700, Srinivas Pandruvada wrote:
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> >  
> > +config PUNIT_ATOM
> > +	bool "ATOM Punit debug driver"
> > +	def_bool n
> 
> The kconfig tools will do what you mean here. But just
> 	default n
> 
> is neater. And, moreover, even that is probably not needed, as n is the
> default anyway.
> 
> > +	depends on DEBUG_FS
> > +	select IOSF_MBI
> > +	---help---
> > +	  This is a debug driver, which gets the power states
> > +	  of all Punit North Complex devices.The power states of
> > +	  each IP is exposed as part of the debugfs interface.
> 
> (This menu will show up in menuconfig's main menu. Shouldn't this be put
> in some debug related menu?)
The initial intention is to make a debug driver only, but there is
possibility that some register setting be allowed from user space for PM
decision. So leaving open this possibility to keep out of debug menus.

<snip>

> And these three macros will be effectively preprocessed away for
> built-in only code.
> 
> But, on the other hand, changing PUNIT_ATOM to tristate allows it to be
> built as a module (I just did that). So perhaps that was your intention?
Making tristate makes sense. So I will send an update with this.

Thanks,
Srinivas
> 
> 
> Paul Bolle
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/