Re: [PATCH 2/2] arm64: dts: qcom: Add msm8916 CoreSight components

[Mathieu Poirier]

On 30 April 2015 at 03:24, Ivan T. Ivanov <ivan.ivanov@xxxxxxxxxx> wrote:
>
> On Wed, 2015-04-29 at 10:49 -0600, Mathieu Poirier wrote:
>> On 29 April 2015 at 06:20, Ivan T. Ivanov ivanov@xxxxxxxxxx> wrote:
>
>
>> > +
>> > +       funnel@821000 {
>> > +               compatible = "arm,coresight-funnel", "arm,primecell";
>> > +               reg = <0x821000 0x1000>;
>> > +
>> > +               clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
>> > +               clock-names = "apb_pclk", "atclk";
>> > +
>> > +               ports {
>> > +                       #address-cells = <1>;
>> > +                       #size-cells = <0>;
>> > +
>> > +                       port@4 {
>> > +                               reg = <4>;
>> > +                               funnel0_in4: endpoint {
>> > +                                       slave-mode;
>> > +                                       remote-endpoint = <&funnel1_out>;
>> > +                               };
>> > +                       };
>> > +                       port@8 {
>> > +                               reg = <0>;
>> > +                               funnel0_out: endpoint {
>> > +                                       remote-endpoint = <&etf_in>;
>> > +                               };
>> > +                       };
>>
>> Please add a comment indicating what the other ports are connected to.
>>
>> > +               };
>> > +       };
>> > +
>> > +       replicator@824000 {
>> > +               compatible = "qcom,coresight-replicator", "arm,primecell";
>> > +               reg = <0x824000 0x1000>;
>> > +
>> > +               clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
>> > +               clock-names = "apb_pclk", "atclk";
>> > +
>> > +               ports {
>> > +                       #address-cells = <1>;
>> > +                       #size-cells = <0>;
>> > +
>> > +                       port@0 {
>> > +                               reg = <0>;
>> > +                               replicator_out0: endpoint {
>> > +                                       remote-endpoint = <&etr_in>;
>> > +                               };
>> > +                       };
>> > +                       port@1 {
>> > +                               reg = <1>;
>> > +                               replicator_out1: endpoint {
>> > +                                       remote-endpoint = <&tpiu_in>;
>> > +                               };
>> > +                       };
>> > +                       port@2 {
>> > +                               reg = <0>;
>> > +                               replicator_in: endpoint {
>> > +                                       slave-mode;
>> > +                                       remote-endpoint = <&etf_out>;
>> > +                               };
>> > +                       };
>>
>> Same comment as with the funnel component.
>
> Sorry, but what do you mean here?

My bad - replicators have only one input port and two output ones.
Forget about this comments.

>
> Regards,
> Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/