Re: [RFC PATCH 1/3] mm/thp: Use pmdp_splitting_flush_notify to clear pmd on splitting

[Aneesh Kumar K.V]

"Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx> writes:

>> @@ -184,3 +185,13 @@ void pmdp_invalidate(struct vm_area_struct *vma, unsigned long address,
>>  }
>>  #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
>>  #endif
>> +
>> +#ifndef __HAVE_ARCH_PMDP_SPLITTING_FLUSH_NOTIFY
>> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> +void pmdp_splitting_flush_notify(struct vm_area_struct *vma,
>> +				 unsigned long address, pmd_t *pmdp)
>> +{
>> +	pmdp_clear_flush_notify(vma, address, pmdp);
>> +}
>> +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
>> +#endif
>
> I think it worth inlining. Let's put it to <asm-generic/pgtable.h>
>
> It probably worth combining with collapse counterpart in the same patch.
>

I tried that first, But that pulls in mmu_notifier.h and huge_mm.h
headers and other build failures

-aneesh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/