Re: [PATCH v4 2/8] init.h: add __read_mostly to early_param_on_off()

From: Borislav Petkov
Date: Thu Apr 30 2015 - 14:42:47 EST


On Thu, Apr 30, 2015 at 08:32:00PM +0200, Luis R. Rodriguez wrote:
> In this particular case early_param_on_off() will be used for boot
> time kernel parameters which we do not intend on dynamically change a
> lot at run time, we

It is not about whether you're going to dynamically change it but more
about how often it is accessed. If it is accessed only a couple of times
tops during boot and then never again during the system lifetime - which
is generally the case for most boot params - then you certainly don't
want to pollute the read.mostly section with dead weight. You can just
as well use a stinking normal variable.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/