Re: [PATCH 2/5] arc: use for_each_sg()

[Vineet Gupta]

On Friday 01 May 2015 12:17 PM, Akinobu Mita wrote:
> Since arc doesn't select ARCH_HAS_SG_CHAIN, it is not necessary to
> use for_each_sg() in order to loop over each sg element.  But this can
> help find problems with drivers that do not properly initialize their
> sg tables when CONFIG_DEBUG_SG is enabled.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: Vineet Gupta <vgupta@xxxxxxxxxxxx>
> Cc: linux-arch@xxxxxxxxxxxxxxx

Looks fine to me. However it must be noted (perhaps add to change log) that this
will lead to different generated code as sg_next() is a function call etc. So this
change is strictly not equivalent to what we had before.

Acked-by: Vineet Gupta <vgupta@xxxxxxxxxxxx>

Thx,
-Vineet


> ---
>  arch/arc/include/asm/dma-mapping.h | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arc/include/asm/dma-mapping.h b/arch/arc/include/asm/dma-mapping.h
> index 45b8e0c..f787894 100644
> --- a/arch/arc/include/asm/dma-mapping.h
> +++ b/arch/arc/include/asm/dma-mapping.h
> @@ -178,22 +178,24 @@ dma_sync_single_range_for_device(struct device *dev, dma_addr_t dma_handle,
>  }
>  
>  static inline void
> -dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nelems,
> +dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sglist, int nelems,
>  		    enum dma_data_direction dir)
>  {
>  	int i;
> +	struct scatterlist *sg;
>  
> -	for (i = 0; i < nelems; i++, sg++)
> +	for_each_sg(sglist, sg, nelems, i)
>  		_dma_cache_sync((unsigned int)sg_virt(sg), sg->length, dir);
>  }
>  
>  static inline void
> -dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg, int nelems,
> -		       enum dma_data_direction dir)
> +dma_sync_sg_for_device(struct device *dev, struct scatterlist *sglist,
> +		       int nelems, enum dma_data_direction dir)
>  {
>  	int i;
> +	struct scatterlist *sg;
>  
> -	for (i = 0; i < nelems; i++, sg++)
> +	for_each_sg(sglist, sg, nelems, i)
>  		_dma_cache_sync((unsigned int)sg_virt(sg), sg->length, dir);
>  }
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/