Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3]

[David Howells]

Michal Marek <mmarek@xxxxxxx> wrote:

> > +		ERR(asprintf(&dest_name, "%s.~signed~", module_name) < 0,
> > +		    "asprintf");
> > +		replace_orig = true;
> > +	}
> > +
> > +	ERR_load_crypto_strings();
> > +	ERR_clear_error();
> 
> The error queue initialization should be done before the first use of
> the ERR() macro. Or the asprintf check should be open-coded, because it
> has nothing to do with openssl.

Good point.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/