Re: [PATCH 3/5] blk-mq: fix plugging in blk_sq_make_request

[Christoph Hellwig]

> -	if (use_plug && !blk_queue_nomerges(q) &&
> +	if (likely(!is_flush_fua) && !blk_queue_nomerges(q) &&

Please don't sprinkle likely annotations for no go reason.  Especially
on metadata write heavy workloads (e.g. an NFS server) it might be very
likely.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/