Re: [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out

[Jeff Moyer]

Shaohua Li <shli@xxxxxx> writes:

> V2: don't change ->in_iowait
>
> Cc: NeilBrown <neilb@xxxxxxx>
> Signed-off-by: Shaohua Li <shli@xxxxxx>
> ---
>  kernel/sched/core.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index f9123a8..1ab3d2d 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -4402,10 +4402,7 @@ long __sched io_schedule_timeout(long timeout)
>  	long ret;
>  
>  	current->in_iowait = 1;
> -	if (old_iowait)
> -		blk_schedule_flush_plug(current);
> -	else
> -		blk_flush_plug(current);
> +	blk_schedule_flush_plug(current);
>  
>  	delayacct_blkio_start();
>  	rq = raw_rq();

Looks good to me.

Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/