Re: [PATCH] KVM: x86: dump VMCS on invalid entry

[Paolo Bonzini]

On 30/04/2015 20:17, Bandan Das wrote:
>> > Code and format roughly based on Xen's vmcs_dump_vcpu.
> Nice, but isn't it better to keep the output format and behavior the
> same for both dump_vmcb and dump_vmcs() ? why not pr_error ?

I didn't think of looking at dump_vmcb. :)  I knew it existed, but I
didn't remember it's called in these exact circumstances.

The output seems a bit too verbose for pr_error...  Maybe it's worth
changing dump_vmcb instead.  Regarding the output format, some things
could be adjusted to match (especially the segments) but overall the
data is pretty different apart from the segments and a handful of other
fields.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/