Re: [PATCH 2/7] x86/intel_rdt: Adds support for Class of service management

[Peter Zijlstra]

On Fri, May 01, 2015 at 06:36:36PM -0700, Vikas Shivappa wrote:
> +static inline bool cat_supported(struct cpuinfo_x86 *c)

Is search and replace really that hard?

> +/*
> +* Called with the rdt_group_mutex held.
> +*/

Whitespace damaged and pointless comment.

> +static int rdt_free_closid(struct intel_rdt *ir)
> +{
> +

superfluous whitespace

> +	lockdep_assert_held(&rdt_group_mutex);
> +
> +	WARN_ON(!ccmap[ir->clos].cgrp_count);
> +	ccmap[ir->clos].cgrp_count--;
> +	if (!ccmap[ir->clos].cgrp_count)
> +		clear_bit(ir->clos, rdtss_info.closmap);
> +
> +	return 0;
> +}


These patches really are very sloppy.. 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/