Re: [PATCH RFC 1/2] crypto: add PKE API

From: Herbert Xu
Date: Sat May 02 2015 - 20:08:31 EST


On Fri, May 01, 2015 at 11:17:44AM -0700, Tadeusz Struk wrote:
>
> I'm fine with pkey. Herbert do you have preference with regards 'algo' vs 'alg'?

For interfaces with the crypto API alg should be used otherwise
you can use algo or whatever you like.

> >> #define CRYPTO_ALG_TYPE_AHASH 0x0000000a
> >> > +#define CRYPTO_ALG_TYPE_PKE 0x0000000b
> >> > #define CRYPTO_ALG_TYPE_RNG 0x0000000c
> > Will filling a hole cause a problem with something that got obsoleted?
>
> I hope not. I checked as far back as 2.6.18 and I don't see any clash.
> Herbert, what do you think?

Indeed you can't use this hole as it'll make you a hash algorithm.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/