Re: [PATCH 1/2] brcmfmac: prohibit ACPI power management for brcmfmac driver

[Fu, Zhonghui]

On 2015/4/27 16:59, Arend van Spriel wrote:
> On 04/27/15 07:00, Fu, Zhonghui wrote:
>> ACPI will manage WiFi chip's power state during suspend/resume
>> process on some tablet platforms(such as ASUS T100TA). This is
>> not supported by brcmfmac driver now, and the context of WiFi
>> chip will be damaged after resume. This patch disconnects the
>> relationship between WiFi chip and it's ACPI companion, and
>> prohibit ACPI PM for it.
>
> Nice. However, ACPI may contain configuration data that brcmfmac needs on some platforms and Adrian Hunter is looking into this. So it is probably better to do this operation at the end of the probe before returning successful.
Your comment is right. I introduced another implementation in new patch - "[PATCH v2] brcmfmac: prohibit ACPI power management for brcmfmac driver".


Thanks,
Zhonghui
>
> Regards,
> Arend
>
>> Signed-off-by: Zhonghui Fu<zhonghui.fu@xxxxxxxxxxxxxxx>
>> ---
>>   drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/