Re: [PATCH 1/3] Add patman patch automation script
From: Richard Weinberger
Date: Sun May 03 2015 - 16:44:16 EST
Am 03.05.2015 um 22:40 schrieb Simon Glass:
>> But I don't think it makes much sense to carry it with the Linux kernel tree.
>> Other projects can also use it and it does not seem to be very Linux kernel
>> specific.
>> git, quilt and other great tools also have their own repositories.
>
> My reasoning is that:
>
> - more will find it / use it if it is in-tree
> - it avoids installation and old-version problems (e.g. I suppose this
> is why the device tree compiler is built-in)
> - it is somewhat Linux-specific (e.g. uses get_maintainers,
> checkpatch.pl) and can break if checkpatch.pl if the wrong version
> (e.g. you check out and send patches from an older tree)
> - it could be built into the Linux workflow [1] and might thereby
> reduce the amount of confusion and errors (did you run checkpatch?,
> your change log is in the wrong place, you forgot to add your
> sign-off, etc.)
If we'd follow these arguments we'd have to move the whole GNU into the
kernel tree. ;-)
checkpatch.pl and get_maintainers.pl are not really a show-stopper.
Other projects are using them too. You can make them also configurable.
i.e. check_script and get_maintaner_script.
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/