Re: [PATCH 0/2] mmc: cast to avoid unexpected error

From: Ulf Hansson
Date: Mon May 04 2015 - 06:46:45 EST


On 14 April 2015 at 06:06, Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> Hi Ulf
>
> These are non RFC version of mmc data cast patches
> which were posted in
> Subject: [PATCH 0/2][RFC] mmc: cast to avoid unexpected error
> Date: Wed, 8 Apr 2015 07:32:35 +0000
>
> These 2 patches adds cast to avoid unexpected error.
> It tries copy to u64 without cast.
> The data will be 0xfff... if last bit was 1.
> These are reported by coverity tool.
> I'm happy if someone tests it, or can get deep review.
>
> Kuninori Morimoto (2):
> mmc: cast u8 to unsigned long long to avoid unexpected error
> mmc: cast unsigned int to typeof(sector_t) to avoid unexpected error
>
> drivers/mmc/card/block.c | 2 +-
> drivers/mmc/core/mmc.c | 6 ++++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Please run another round of checkpatch for these.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/