Re: [RFT][PATCH 2/2] regulator: max77843: Convert to use regulator_is_enabled_regmap

[Krzysztof KozÅowski]

2015-05-04 21:28 GMT+09:00 Mark Brown <broonie@xxxxxxxxxx>:
> On Fri, May 01, 2015 at 04:54:08PM +0900, Krzysztof KozÅowski wrote:
>> 2015-05-01 15:17 GMT+09:00 Axel Lin <axel.lin@xxxxxxxxxx>:
>
>> > Use regulator_is_enabled_regmap() to replace max77843_reg_is_enabled().
>
>> I did not update the max77843 driver with such change (as did for max77693)
>> because I think they should be merged:
>> https://lkml.org/lkml/2015/4/29/185
>> These devices are almost the same.
>
> I can't see that link since I don't have internet access right now but
> surely it's going to be clearer that the code for the devices is the
> same if we make updates like this to both devices?  Otherwise it's less
> obvious on review.

Yes, indeed. The patch itself looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@xxxxxxxxx>

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/