Re: [PATCH 10/10] perf tools: Move TUI-specific fields out of map_symbol

[Arnaldo Carvalho de Melo]

Em Wed, Apr 22, 2015 at 04:18:21PM +0900, Namhyung Kim escreveu:
> The has_children and unfolded fields don't belong to struct map_symbol
> since they're used by TUI only.  Move those fields out of map_symbol
> since the struct is also used by other places.
> 
> This will also help to compact the sizeof struct hist_entry.

So, while testing your 'perf kmem' patchkit, I noticed that I couldn't,
on a 'perf report --no-ch' (probably affects the children case as well,
have not tested that), expand the first callchain entry, I did a bisect
on my perf/core branch and it ended in this patch:


[acme@ssdandy linux]$ git bisect good 
7ee14d744acb33e5b3114484d7d850caecb339a2 is the first bad commit
commit 7ee14d744acb33e5b3114484d7d850caecb339a2
Author: Namhyung Kim <namhyung@xxxxxxxxxx>
Date:   Wed Apr 22 16:18:21 2015 +0900

    perf tools: Move TUI-specific fields out of map_symbol
    
    The has_children and unfolded fields don't belong to struct map_symbol
    since they're used by TUI only.  Move those fields out of map_symbol
    since the struct is also used by other places.
    
    This will also help to compact the sizeof struct hist_entry.
    
    Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
    Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
    Cc: David Ahern <dsahern@xxxxxxxxx>
    Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
    Link: http://lkml.kernel.org/r/1429687101-4360-11-git-send-email-namhyung@xxxxxxxxxx
    Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

:040000 040000 a72f0be94a86bbdad1cc38d0ce1e8578337612f4 4f84cc2bac01666a97b918aef0151b07e9a4015c M	tools
[acme@ssdandy linux]$ 

So I am moving this series to the top of perf/core and then moving it to a
separate branch, so that you can try to reproduce this and I can push the rest
to Ingo, ok?

Ah, while trying to find new_slab() in callchains one other thing I tried was
to press 'E', to expand all the callchains, and it segfaulted, unsure if this
is related.

Will send another message with the branch details when done.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/