Re: [PATCH 4/7] staging: fsl-mc: Upgraded MC bus driver to match MC fw 7.0.0

[Dan Carpenter]

On Mon, May 04, 2015 at 11:58:13PM +0000, Jose Rivera wrote:
> > 
> > On Tue, Apr 28, 2015 at 12:39:07PM -0500, J. German Rivera wrote:
> > > - Migrated MC bus driver to use DPRC flib 0.6.
> > 
> > What does this mean?  What is a flib?
> > 
> The DPRC flib is the API to manipulate DPRC objects. 
> 
> > After reading the patch, apparently it means that we can remove all the
> > ifdefs from patch 1.  :)
> > 
> No, we cannot as the required GIC-ITS support is not upstream yet.
> I added some of the #ifdefs back that were removed by mistake.
> 
> > > - Changed IRQ setup infrastructure to be able to program MSIs
> > >   for MC objects in an object-independent way.
> > 
> > Are these two things related?
> > 
> No.

When I asked this function I was partly wondering why they were broken
up the way they are.  This changelog was not enough information to start
reviewing the patch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/