Re: [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation

[Leonardo Carreras]

Dear Dan,

On Tue, May 5, 2015 at 4:58 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Mon, May 04, 2015 at 09:32:27PM -0400, Leonardo Carreras wrote:
>> Removed checkpatch reported spaces in indentation.
>>
>> Signed-off-by: Leonardo Carreras <leocarreras89@xxxxxxxxx>
>> ---
>>  drivers/dma/amba-pl08x.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
>> index 49d396e..a76df61 100644
>> --- a/drivers/dma/amba-pl08x.c
>> +++ b/drivers/dma/amba-pl08x.c
>> @@ -474,7 +474,7 @@ static void pl08x_terminate_phy_chan(struct pl08x_driver_data *pl08x,
>>       u32 val = readl(ch->reg_config);
>>
>>       val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
>> -              PL080_CONFIG_TC_IRQ_MASK);
>> +             PL080_CONFIG_TC_IRQ_MASK);
>
> Yeah, but now it doesn't line up correctly.
>
> Do it like this:
>
>         val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
>                  PL080_CONFIG_TC_IRQ_MASK);
>
> In other words:
>
> [tab][space]PL080_CONFIG_TC_IRQ_MASK);
>

I will check this, but may I ask if that would be marked as an error
by checkpatch.

Regards,

Leo

> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/