Re: [PATCH v2] perf kmem: Show warning when trying to run stat without record

[Pekka Enberg]

On 05/05/2015 05:07 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 05, 2015 at 09:58:12AM +0900, Namhyung Kim escreveu:
> > Sometimes one can mistakenly run perf kmem stat without perf kmem
> > record before or different configuration like recoding --slab and stat
> > --page.  Show a warning message like below to inform user:
> >
> >    # perf kmem stat --page --caller
> >    Not found page events.  Have you run 'perf kmem record --page' before?
> >
> > Acked-by: Pekka Enberg <penberg@xxxxxxxxxx>
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> Thanks, applied.
>
> I just found the messages a bit odd souding, perhaps:
>
>     # perf kmem stat --page --caller
>     No page allocation events found.  Have you run 'perf kmem record --page'?
>
> Pekka?

Sure, that sounds less confusing.

- Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/