Re: [PATCH] remove <asm/scatterlist.h>

[Geert Uytterhoeven]

On Tue, May 5, 2015 at 10:41 PM, Christoph Hellwig <hch@xxxxxx> wrote:
> On Tue, May 05, 2015 at 10:34:21PM +0200, Geert Uytterhoeven wrote:
>> If you remove include/asm-generic/scatterlist.h, you have to update the
>> various Kbuild files referring to it:
>
> Oh, I missed that and will fix it.  But where does the missing removal
> actually show up?  During a normal build on a few architectures nothing
> seemed to care.

There are indeed no errors or warnings from Kbuild if you remove a
file from include/asm-generic. Only if you try to #include it, it will fail.

Ah, it just creates a file that includes the generic version, whether it
exists or not:

$ cat arch/arm/include/generated/asm/scatterlist.h
#include <asm-generic/scatterlist.h>
$

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/