Re: [PATCH resend 4/5] score: Fix exception handler label

From: Lennox Wu
Date: Tue May 05 2015 - 22:00:49 EST


Hi Roeck,
You are right! I will push the patch.
Thank you.

Acked-by: Lennox Wu <lennox.wu@xxxxxxxxx>

2015-05-05 6:30 GMT+08:00 Guenter Roeck <linux@xxxxxxxxxxxx>:
> The latest version of modinfo fails to compile score architecture
> targets with the following error.
>
> FATAL: The relocation at __ex_table+0x634 references
> section "__ex_table" which is not executable, IOW
> the kernel will fault if it ever tries to
> jump to it. Something is seriously wrong
> and should be fixed.
>
> The probem is caused by a bad label in an __ex_table entry.
>
> Cc: Quentin Casasnovas <quentin.casasnovas@xxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> Please consider pushing this patch into mainline, or provide feedback
> on how to improve it to be acceptable.
>
> arch/score/lib/string.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/score/lib/string.S b/arch/score/lib/string.S
> index 00b7d3a2fc60..16efa3ad037f 100644
> --- a/arch/score/lib/string.S
> +++ b/arch/score/lib/string.S
> @@ -175,10 +175,10 @@ ENTRY(__clear_user)
> br r3
>
> .section .fixup, "ax"
> +99:
> br r3
> .previous
> .section __ex_table, "a"
> .align 2
> -99:
> .word 0b, 99b
> .previous
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/