Re: [PATCH 2/2] adm8211: fix the possible pci cache line sizes inside switch-case

From: Kalle Valo
Date: Wed May 06 2015 - 00:59:20 EST


Okash Khawaja <okash.khawaja@xxxxxxxxx> writes:

> The PCI cache line size value was being compared against decimal values prefixed with 0x.
>
> Fixed the literals to use the correct hex values.
>
>
> Signed-off-by: Okash Khawaja <okash.khawaja@xxxxxxxxx>

[...]

> @@ -1101,10 +1101,10 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
> case 0x8:
> reg |= (0x1 << 14);
> break;
> - case 0x16:
> + case 0x10:
> reg |= (0x2 << 14);
> break;
> - case 0x32:
> + case 0x20:
> reg |= (0x3 << 14);
> break;
> default:

Did you test this? How certain can we be that this doesn't break
anything?

--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/