Re: [PATCH 01/10] block: make generic_make_request handle arbitrarily sized bios

[Christoph Hellwig]

On Tue, May 05, 2015 at 11:08:20PM -0700, Ming Lin wrote:
> How about below incremental patch?

> -
> -		/*
> -		 * If the queue doesn't support SG gaps and adding this
> -		 * offset would create a gap, disallow it.
> -		 */
> -		if (q->queue_flags & (1 << QUEUE_FLAG_SG_GAPS) &&
> -		    bvec_gap_to_prev(prev, offset))
> -			return 0;

You need to keep the explicit checks for the BLOCK_PC case, as we can't
split those.

Otherwise it looks fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/