Re: [PATCH 47/79] namei: move link/cookie pairs into nameidata

[Al Viro]

On Wed, May 06, 2015 at 12:42:54PM +1000, NeilBrown wrote:
> >  static int link_path_walk(const char *name, struct nameidata *nd)
> >  {
> > -	struct saved {
> > -		struct path link;
> > -		void *cookie;
> > -		const char *name;
> > -	} stack[MAX_NESTED_LINKS], *last = stack + nd->depth - 1;
> > +	struct saved *last = nd->stack;
> 
> This looks wrong.  'last'  used to be dependent on nd->depth, now it isn't.

On the entry to link_path_walk() we have nd->depth == 0.

And nd->depth and last are changed in sync.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/