RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

[Alan Stern]

On Wed, 6 May 2015, Ramneek Mehresh wrote:

> > Also, I'm not going to let you add new fields into the ehci_driver_overrides
> > structure.  If you really need to override other routines, copy the approach
> > used by ehci-tegra.c.
> > 
> Understood...but I would appreciate if you could please explain the harm in doing so

The fields in the override structure are meant for convenience.  The
extra_priv_size field is the most important one; the other two fields
(reset and port_power) are present only because so many drivers need
them.

There's no reason to add an extra field for something that will be used 
in only one driver.  You can do the override by hand, instead of 
wasting space in a whole bunch of other drivers.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/