Re: [RFC PATCH 0/9] Add self-probe infrastructure and stacked irqdomain support for ACPI based GICv2/3 init

[Lorenzo Pieralisi]

On Wed, May 06, 2015 at 04:00:32AM +0100, Hanjun Guo wrote:
> On 2015???05???06??? 04:28, Rafael J. Wysocki wrote:
> > On Tuesday, May 05, 2015 09:50:48 PM Hanjun Guo wrote:
> >> This patch set introduce self-probe infrastructure to init IRQ
> >> controllers and stacked irqdomain support for ACPI based GICv2/3
> >> init.
> >>
> >> The self-probe infrastructure for ACPI GIC init is similar as
> >> IRQCHIP_DECLARE() and based on the GIC version support in ACPI
> >> MADT table.
> >>
> >> We introduce acpi_irq_domain for GICv2/3 core domain to support
> >> stacked irqdomain, and pass the gsi (global system interrupt) as
> >> the agument (void *arg) for gic_irq_domain_alloc(), then we can
> >> alloc virqs via acpi_register_gsi() with stacked irqdomain.
> >>
> >> I already compiled this patch set ok with both ACPI=on/off on
> >> ARM64 and also compiled ok on x86, tested with GICv2 init on
> >> FVP model and it boot successfully.
> >>
> >> Next step I would consolidate all the ACPI GIC init into one
> >> file -- drivers/irqchip/irq-gic-acpi.c, and introduce ITS and
> >> IORT support.
> >>
> >> please comment on this patchset to see if we are on the right
> >> direction.
> >>
> >> Hanjun Guo (6):
> >>    irqchip / gic: Add GIC version support in ACPI MADT
> >>    irqchip: gic: ACPI: Use IRQCHIP_ACPI_DECLARE to simplify GICv2 init
> >>      code
> >>    irqchip / gic: Add stacked irqdomain support for ACPI based GICv2 init
> >>    ACPI / gsi: Add gsi_mutex to synchronize
> >>      acpi_register_gsi()/acpi_unregister_gsi()
> >>    irqchip / GICv3: Add ACPI support for GICv3+ initialization
> >>    irqchip / GICv3: Add stacked irqdomain support for ACPI based init
> >>
> >> Tomasz Nowicki (3):
> >>    ACPICA: Introduce GIC version for arm based system
> >>    ACPI / irqchip: Add self-probe infrastructure to initialize IRQ
> >>      controller
> >>    irqchip / GICv3: Refactor gic_of_init() for GICv3 driver
> >>
> >>   arch/arm64/Kconfig                   |   1 +
> >>   arch/arm64/include/asm/irq.h         |  13 --
> >>   arch/arm64/kernel/acpi.c             |  25 ----
> >>   drivers/acpi/Makefile                |   1 +
> >>   drivers/acpi/gsi.c                   |  39 ++---
> >>   drivers/acpi/irq.c                   |  40 ++++++
> >>   drivers/irqchip/Kconfig              |   3 +
> >>   drivers/irqchip/Makefile             |   1 +
> >>   drivers/irqchip/irq-gic-acpi.c       | 116 +++++++++++++++
> >>   drivers/irqchip/irq-gic-v3.c         | 267 ++++++++++++++++++++++++++++-------
> >>   drivers/irqchip/irq-gic.c            |  38 ++---
> >>   drivers/irqchip/irqchip.h            |  12 ++
> >>   include/acpi/actbl1.h                |  17 ++-
> >>   include/asm-generic/vmlinux.lds.h    |  13 ++
> >>   include/linux/acpi.h                 |  14 ++
> >>   include/linux/acpi_irq.h             |   4 +-
> >>   include/linux/irqchip/arm-gic-acpi.h |  12 +-
> >>   include/linux/mod_devicetable.h      |   7 +
> >>   18 files changed, 489 insertions(+), 134 deletions(-)
> >>   create mode 100644 drivers/acpi/irq.c
> >>   create mode 100644 drivers/irqchip/irq-gic-acpi.c
> >
> > What's the connection between this and the Jiang Liu's patchset?
> 
> If you are mentioning Jiang Liu's patchset (Consolidate ACPI PCI
> root common code into ACPI core), there is no direct connection
> with my patchset, but this patch set is based on stacked irqdomain
> which was introduced by Jiang Liu, and this is needed to support
> PCI MSI on ARM64 in ACPI way.

Well, there is no direct connection but the two sets are fundamental
to get PCIe ACPI support on arm64, as you mentioned this patchset is a
requirement (stacked domains) for introducing ACPI PCI MSI support on
arm64, that should be done with a separate patch on top of this series
(I have one but first I have to find a decent solution for
ACPI MSI frame <-> device matching).

Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/