Re: [PATCH] iio: hid-sensors: Fix memory leak on failure path in hid_prox_probe()

[Alexey Khoroshilov]

On 07.05.2015 01:32, Fabio Estevam wrote:
> On Wed, May 6, 2015 at 7:14 PM, Alexey Khoroshilov
> <khoroshilov@xxxxxxxxx> wrote:
> 
>> Not exactly. Other calls are after
>>   indio_dev->channels = channels;
>> So,
>> error_free_dev_mem:
>>         kfree(indio_dev->channels);
>> works for them well.
> 
> indio_dev is allocated using devm_ , so you don't need to free it.
> 
> Your patch is not correct because you only  kfree(channels) in the
> prox_parse_report() error case, but you missed the other subsequent
> functions.
> 

No! The other subsequent functions are AFTER (prox_parse_report() error
case is the only BEFORE)
  indio_dev->channels = channels;

and all consequent error cases comes to error_free_dev_mem, where

error_free_dev_mem:
       kfree(indio_dev->channels);

that is equivalent to kfree(channels);

--
Alexey


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/