Re: tools: Consolidate types.h

[Andy Lutomirski]

On Wed, May 6, 2015 at 10:37 AM, Borislav Petkov <bp@xxxxxxx> wrote:
> On Wed, May 06, 2015 at 07:30:35PM +0200, Oleg Nesterov wrote:
>> On 05/06, Borislav Petkov wrote:
>> >
>> > On Wed, May 06, 2015 at 06:54:00PM +0200, Oleg Nesterov wrote:
>> > > Hi,
>> > >
>> > > I can't build the kernel after "git pull",
>> >
>> > You mean, you can't build perf tool...?
>>
>> No, make bzImage fails, it can't compile arch/x86/vdso/vdso2c
>
> Wow, so this commit is a year old and this is the first time I see a it
> causing a failure. You must have a really ooold distro :-)
>
>> > > diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
>> > > index 275a3a8..e970320 100644
>> > > --- a/arch/x86/vdso/Makefile
>> > > +++ b/arch/x86/vdso/Makefile
>> > > @@ -51,7 +51,7 @@ VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
>> > >  $(obj)/vdso64.so.dbg: $(src)/vdso.lds $(vobjs) FORCE
>> > >   $(call if_changed,vdso)
>> > >
>> > > -HOST_EXTRACFLAGS += -I$(srctree)/tools/include -I$(srctree)/include/uapi
>> > > +HOST_EXTRACFLAGS += -I$(srctree)/tools/include -I$(srctree)/include/uapi -I$(srctree)/arch/x86/include/uapi
>> >
>> > Do you have kernel-headers installed on your distro?
>>
>> I have no idea ;) but I guess they were installed. many years ago.
>>
>> > That's
>> > basically those uapi headers packaged separately. There's also "make
>> > headers_install" which should probably do that (haven't tried it
>> > though).
>>
>> Perhaps. but still, if HOST_EXTRACFLAGS has -I$(srctree)/include/uapi, why
>> it doesn't add arch/x86/include/uapi? This doesn't look consistent in any
>> case.
>
> Yeah, I guess it wouldn't hurt. Andy, see quoted hunk above ^^.

I'd be fine with adding the extra -I.  Want to send a pach?  I'll get
to it eventually if you don't beat me to it.

--Andy

>
> --
> Regards/Gruss,
>     Boris.
>
> ECO tip #101: Trim your mails when you reply.
> --



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/