Re: [PATCH] staging: fbtft: force cast to non-__iomem pointer

From: Dan Carpenter
Date: Thu May 07 2015 - 04:39:40 EST


On Wed, May 06, 2015 at 02:34:49PM -0700, Garret Kelly wrote:
> > Can't we fix this properly, to use the correct type of pointer instead
> > for non-__iomem allocations?
>
> You mean making an alternate screen_base pointer inside fb_info that
> isn't __iomem? There are already a bunch of framebuffer drivers that
> (ab)use screen_base to store non-__iomem pointers, so this didn't
> strike me as too far out of line.

You could add a new pointer or you could just make ->screen_base a
union. I'm not sure which is the best.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/