Re: [PATCH] MODSIGN: Change default key details [ver #2]

[Michal Marek]

On 2015-05-07 13:00, David Howells wrote:
> Michal Marek <mmarek@xxxxxxx> wrote:
> 
>> are you fine with these two patches?
>>
>>   https://lkml.org/lkml/2015/2/20/546
>>   https://lkml.org/lkml/2015/5/4/614
> 
> Yeah, I think so.  Your reasoning on the first one is sound - but is it
> possible for $(objtree) to != $(srctree) even when they're coincident.

This part is fine. $(objtee) is always '.', the variable is only used as
an annotation. You can of course do 'make O=/symlink/to/current/dir',
but this will fail with

  /your/current/dir is not clean, please run 'make mrproper'


> I like
> Linus's use of the filechk macro on the second - but we shouldn't overwrite
> keys someone has manually placed in the tree if the key generation template
> changes due to git pull altering kernel/Makefile.

That's the problem with allowing a file to be either user-supplied or
generated. We can use separate files for the user-supplied/generated
cases like below and solve this for good. Not signed off yet, because it
is only lightly tested and the clean rules and .gitignore need to be
updated.

Michal