Re: [STLinux Kernel] [PATCH 06/12] watchdog: bindings: Supply knowledge of a third supported device - clocksource

[Peter Griffin]

Hi Lee,

On Thu, 07 May 2015, Lee Jones wrote:

> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt
> index 388c88a..0b1a784 100644
> --- a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt
> @@ -1,20 +1,23 @@
>  STMicroelectronics Low Power Controller (LPC) - Watchdog
>  ========================================================
>  
> -LPC currently supports Watchdog OR Real Time Clock functionality.
> +LPC currently supports Watchdog OR Real Time Clock OR Clocksource
> +functionality.
>  
>  [See: ../rtc/rtc-st-lpc.txt for RTC options]
> +[See: ../timer/st,stih407-lpc for Clocksource options]
>  
>  Required properties
>  
> -- compatible 	: Must be one of: "st,stih407-lpc" "st,stih416-lpc"
> -				  "st,stih415-lpc" "st,stid127-lpc"
> +- compatible 	: Must be one of: "st,stih407-lpc"

The same comment as the RTC DT patch, you are removing the compatibles
documentation for the other supported platforms like stih416-lpc.
AFAIK they are required in the driver to get the correct sysconfig register.

regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/