Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

[Mark Brown]

On Thu, May 07, 2015 at 02:38:52PM -0500, Michael Welling wrote:
> On Thu, May 07, 2015 at 08:27:58PM +0100, Mark Brown wrote:
> > On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote:
> > > On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote:

> > > I noticed a few oddities in the code when converting.

> > > For instance:
> > > http://lxr.free-electrons.com/source/drivers/spi/spi-omap2-mcspi.c#L1225

> > > What is the point of trying to print tx or rx given the if statement
> > > insures that rx_buff and tx_buff are NULL?

> > I expect it's just a buggy test.

> Not sure I understand what you mean.

I expect that the code is just being silly.

Attachment: signature.asc
Description: Digital signature