Re: [PATCH v2] nand: Add NAND driver for Mikrotik RB4xx series boards

From: Bert Vermeulen
Date: Fri May 08 2015 - 10:29:41 EST


On 05/08/2015 12:14 PM, Frans Klaver wrote:
> On Thu, May 7, 2015 at 2:31 PM, Bert Vermeulen <bert@xxxxxxxx> wrote:
>> +
>> + info->chip.priv = info;
>> + info->mtd.priv = &info->chip;
>> + info->mtd.owner = THIS_MODULE;
>
> If you should respin, could you add
>
> info->mtd.dev.parent = &pdev->dev;
>
> This will have a symlink to the parent device show up in sysfs. Seems
> some people feel rather strongly about that.

Sure, will do. I'll wait for some comment from David Woodhouse or Brian
Norris first, in case there's something more substantial to fix as well.


--
Bert Vermeulen bert@xxxxxxxx email/xmpp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/