Re: [PATCH] module: Call module notifier on failure after complete_formation()

From: Rusty Russell
Date: Fri May 08 2015 - 20:13:27 EST


Steven Rostedt <rostedt@xxxxxxxxxxx> writes:
> On Fri, 8 May 2015 11:17:36 -0400
> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
>>
>> The module notifier call chain for MODULE_STATE_COMING was moved up before
>> the parsing of args, into the complete_formation() call. But if the module failed
>> to load after that, the notifier call chain for MODULE_STATE_GOING was
>> never called and that prevented the users of those call chains from
>> cleaning up anything that was allocated.
>>
>> Link: http://lkml.kernel.org/r/554C52B9.9060700@xxxxxxxxx
>
> You can nuke the "Link". I didn't realize Pontus didn't Cc any mailing
> lists, and I manually just added it. Usually my scripts will check if
> lkml was Cc'd and only add the "Link" tag if it was. Just shows you
> that my scripts are smarter than I am.

Thanks for this.

Applied,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/