Re: [PATCH] net: fec: add support of ethtool get_regs

From: Philippe Reynes
Date: Sat May 09 2015 - 18:16:36 EST

Hi Fabio,

On 09/05/15 23:59, Fabio Estevam wrote:

On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:

Using memcpy_fromio() to copy device registers is not a good idea -
it can use a variable access size which can cause bus faults.

An example on how memcpy_fromio() can be avoided in get_regs:

Thanks for pointing me this example. I've already send a patch,
and I've used drivers/net/ethernet/freescale/gianfar_ethtool.c
as example. I hope it's a good example too.


Fabio Estevam

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at