Re: [PATCH v5 2/2] ARM: at91/dt: add support for kizboxmini

[Nicolas Ferre]

Le 04/05/2015 17:59, GaÃl PORTAY a Ãcrit :
> Add DT file for Kizbox mini board.
> This board is based on Atmel's AT91SAM9G25 SoC.
> 
> Signed-off-by: GaÃl PORTAY <g.portay@xxxxxxxxxxx>
> Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>

Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
Nitpicking below...

> ---
>  arch/arm/boot/dts/Makefile            |   1 +
>  arch/arm/boot/dts/at91-kizboxmini.dts | 130 ++++++++++++++++++++++++++++++++++
>  2 files changed, 131 insertions(+)
>  create mode 100644 arch/arm/boot/dts/at91-kizboxmini.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 21726fd..4bf72c0 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -30,6 +30,7 @@ dtb-$(CONFIG_SOC_SAM_V4_V5) += \
>  	at91sam9rlek.dtb \
>  	at91-ariag25.dtb \
>  	at91-cosino_mega2560.dtb \
> +	at91-kizboxmini.dtb \
>  	at91sam9g15ek.dtb \
>  	at91sam9g25ek.dtb \
>  	at91sam9g35ek.dtb \
> diff --git a/arch/arm/boot/dts/at91-kizboxmini.dts b/arch/arm/boot/dts/at91-kizboxmini.dts
> new file mode 100644
> index 0000000..7a899ca
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-kizboxmini.dts
> @@ -0,0 +1,130 @@
> +/*
> + * at91-kizboxmini.dts - Device Tree file for Overkiz Kizbox mini board
> + *
> + * Copyright (C) 2014 GaÃl PORTAY <g.portay@xxxxxxxxxxx>
> + *
> + * Licensed under GPLv2 or later.
> + */
> +/dts-v1/;
> +#include "at91sam9g25.dtsi"
> +#include "at91sam9x5.dtsi"

Not needed as already included in at91sam9g25.dtsi: I remove it before
applying the patch.

Bye,

> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> +	model = "Overkiz Kizbox mini";
> +	compatible = "overkiz,kizboxmini", "atmel,at91sam9g25", "atmel,at91sam9x5", "atmel,at91sam9";
> +
> +	chosen {
> +		bootargs = "ubi.mtd=ubi";
> +		linux,stdout-path = &dbgu;
> +	};
> +
> +	memory {
> +		reg = <0x20000000 0x8000000>;
> +	};
> +
> +	clocks {
> +		slow_xtal {
> +			clock-frequency = <32768>;
> +		};
> +
> +		main_xtal {
> +			clock-frequency = <12000000>;
> +		};
> +	};
> +
> +	ahb {
> +		apb {
> +			usart0: serial@f801c000 {
> +				status = "okay";
> +			};
> +
> +			macb0: ethernet@f802c000 {
> +				phy-mode = "rmii";
> +				status = "okay";
> +			};
> +
> +			pwm0: pwm@f8034000 {
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&pinctrl_pwm0_pwm0_1
> +					     &pinctrl_pwm0_pwm1_1>;
> +				status = "okay";
> +			};
> +
> +			dbgu: serial@fffff200 {
> +				status = "okay";
> +			};
> +
> +			watchdog@fffffe40 {
> +				status = "okay";
> +			};
> +		};
> +
> +		usb0: ohci@00600000 {
> +			num-ports = <1>;
> +			status = "okay";
> +		};
> +
> +		usb1: ehci@00700000 {
> +			status = "okay";
> +		};
> +
> +		nand0: nand@40000000 {
> +			nand-bus-width = <8>;
> +			nand-ecc-mode = "hw";
> +			atmel,has-pmecc;
> +			atmel,pmecc-cap = <4>;
> +			atmel,pmecc-sector-size = <512>;
> +			nand-on-flash-bbt;
> +			status = "okay";
> +
> +			bootstrap@0 {
> +				label = "bootstrap";
> +				reg = <0x0 0x20000>;
> +			};
> +
> +			ubi@20000 {
> +				label = "ubi";
> +				reg = <0x20000 0x7fe0000>;
> +			};
> +		};
> +	};
> +
> +	gpio_keys {
> +		compatible = "gpio-keys";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		prog {
> +			label = "PB_PROG";
> +			gpios = <&pioC 17 GPIO_ACTIVE_LOW>;
> +			linux,code = <0x102>;
> +			gpio-key,wakeup;
> +		};
> +
> +		reset {
> +			label = "PB_RST";
> +			gpios = <&pioC 16 GPIO_ACTIVE_LOW>;
> +			linux,code = <0x100>;
> +			gpio-key,wakeup;
> +		};
> +	};
> +
> +	pwm_leds {
> +		compatible = "pwm-leds";
> +
> +		green {
> +			label = "pwm:green:user";
> +			pwms = <&pwm0 0 10000000 0>;
> +			max-brightness = <255>;
> +			linux,default-trigger = "default-on";
> +		};
> +
> +		red {
> +			label = "pwm:red:user";
> +			pwms = <&pwm0 1 10000000 0>;
> +			max-brightness = <255>;
> +			linux,default-trigger = "default-on";
> +		};
> +	};
> +};
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/