Re: [PATCH v3 2/7] Xen / ACPI / processor: use invalid_logical_cpuid()

[Konrad Rzeszutek Wilk]

On Mon, May 11, 2015 at 12:17:14PM +0800, Hanjun Guo wrote:
> Use invalid_logical_cpuid(pr->id) instead of direct comparison.
> 
> Signed-off-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
> CC: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  drivers/xen/xen-acpi-cpuhotplug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/xen-acpi-cpuhotplug.c b/drivers/xen/xen-acpi-cpuhotplug.c
> index 3e62ee4..5a62aa0 100644
> --- a/drivers/xen/xen-acpi-cpuhotplug.c
> +++ b/drivers/xen/xen-acpi-cpuhotplug.c
> @@ -77,7 +77,7 @@ static int xen_acpi_processor_enable(struct acpi_device *device)
>  
>  	pr->id = xen_pcpu_id(pr->acpi_id);
>  
> -	if ((int)pr->id < 0)
> +	if (invalid_logical_cpuid(pr->id))
>  		/* This cpu is not presented at hypervisor, try to hotadd it */
>  		if (ACPI_FAILURE(xen_acpi_cpu_hotadd(pr))) {
>  			pr_err(PREFIX "Hotadd CPU (acpi_id = %d) failed.\n",
> @@ -226,7 +226,7 @@ static acpi_status xen_acpi_cpu_hotadd(struct acpi_processor *pr)
>  		return AE_ERROR;
>  
>  	pr->id = xen_hotadd_cpu(pr);
> -	if ((int)pr->id < 0)
> +	if (invalid_logical_cpuid(pr->id))
>  		return AE_ERROR;
>  
>  	/*
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/