Re: [PATCH v4] net: phy: micrel: Fix regression in kszphy_probe

[Fabio Estevam]

On Mon, May 11, 2015 at 12:21 PM, Niklas Cassel <niklas.cassel@xxxxxxxx> wrote:
> Don't do clock-mode-select if clk == NULL,
> since when building without CONFIG_HAVE_CLK,
> clk_get returns NULL and clk_get_rate returns 0.
>
> Doing clock-mode-select in this cause causes kszphy_probe to
> return -EINVAL and thus prevents the device from being probed.
>
> The original code (before regression) would return 0
> when building without CONFIG_HAVE_CLK.
>
> Cc: stable <stable@xxxxxxxxxxxxxxx> # 3.18+
> 1fadee0c3645 ("net/phy: micrel: Add clock support for
> KSZ8021/KSZ8031")
> Signed-off-by: Niklas Cassel <niklass@xxxxxxxx>

Looks good now:

Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/