Re: [RFC PATCH] lib/vsprintf.c: Simplify uuid_string()

From: Joe Perches
Date: Mon May 11 2015 - 12:49:23 EST

On Mon, 2015-05-11 at 12:32 -0400, George Spelvin wrote:
> I suspect it's a speedup, but since this is not hot code, the important
> part is that it shrinks the function from 332 to 256 bytes.

Joe Perches <joe@xxxxxxxxxxx> wrote:
> shrinking code in vsprintf is always good
> ?
> *p++ = hex[byte >> 4];
> *p++ = hex[byte & 0x0f];


Yes, I ran into that compile problem already. I'd already made
that change (I'm not quite Linus; I do *compile* my untested patches
before posting them), but didn't commit it properly, and when I ran
format-patch... :-(

Since this seems to be a positive reaction, I'll put together a test
harmess and make a proper submission.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at