Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

[Josh Triplett]

On Mon, May 11, 2015 at 11:50:21PM +0200, Paul Bolle wrote:
> On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote:
> > --- /dev/null
> > +++ b/init/Kconfig.expert
> > @@ -0,0 +1,231 @@
> > +menuconfig EXPERT
> > +	bool "Configure standard kernel features (expert users)"
> > +	# Unhide debug options, to make the on-by-default options visible
> > +	select DEBUG_KERNEL
> > +	help
> > +	  This option allows certain base kernel options and settings
> > +          to be disabled or tweaked. This is for specialized
> > +          environments which can tolerate a "non-standard" kernel.
> > +          Only use this if you really know what you are doing.
> 
> Comment here saying
> 	# All entries in this file must have "if EXPERT" after their prompt
> 
> or something to that effect (pending you patch, that is)?

Yeah, I should add such a comment.  I was hoping to make it obsolete via
kconfig changes, but in the interim, sure.

> > +config KALLSYMS
> > +	 bool "Load all symbols for debugging/ksymoops" if EXPERT
> > +	 default y
> > +	 help
> > +	   Say Y here to let the kernel print out symbolic crash information and
> > +	   symbolic stack backtraces. This increases the size of the kernel
> > +	   somewhat, as all symbols have to be loaded into the kernel image.
> > +
> > +config KALLSYMS_ALL
> > +	bool "Include all symbols in kallsyms"
> 
> (For some reason this entry doesn't have if EXPERT but it seems to
> behave as expected. Odd.)

Because it depends on KALLSYMS.  Magic!

> > +	depends on DEBUG_KERNEL && KALLSYMS
> > +	help
> > +	   Normally kallsyms only contains the symbols of functions for nicer
> > +	   OOPS messages and backtraces (i.e., symbols from the text and inittext
> > +	   sections). This is sufficient for most cases. And only in very rare
> > +	   cases (e.g., when a debugger is used) all symbols are required (e.g.,
> > +	   names of variables from the data sections, etc).
> > +
> > +	   This option makes sure that all symbols are loaded into the kernel
> > +	   image (i.e., symbols from all sections) in cost of increased kernel
> > +	   size (depending on the kernel configuration, it may be 300KiB or
> > +	   something like this).
> > +
> > +	   Say N unless you really need all symbols.
> > +
> > +config PRINTK
> > +	default y
> > +	bool "Enable support for printk" if EXPERT
> 
> Now you're touching this: bool [...] as the first line, please.

I'd like the commit moving these to their own file to very obviously
look like it's moving these lines unmodified, rather than making changes
in the process.  If you want this (and all the subsequent instances you
flagged) cleaned up, let's do that as a subsequent patch separate from
the move.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/