Re: [PATCH v3 05/22] posix-timers:Convert to the 64bit methods for the timer_gettime syscall function

[Thomas Gleixner]

On Tue, 12 May 2015, Baolin Wang wrote:

> On 12 May 2015 at 00:30, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> 
> > On Monday 11 May 2015 19:15:14 Baolin Wang wrote:
> > > +static int default_timer_get64(struct k_itimer *timr,
> > > +                              struct itimerspec64 *cur_setting64)
> > > +{
> > > +       struct itimerspec cur_setting;
> > > +       struct k_clock *kc = clockid_to_kclock(timr->it_clock);
> > > +
> > > +       kc->timer_get(timr, &cur_setting);
> > > +       return 0;
> > > +}
> >
> > This function is unfortunately incorrect, because you never copy
> > the cur_setting value into cur_setting64.
> 
> Thanks for your comments. But i think this is just a temporary
> default function, and will be removed after all the drivers'
> conversion, so just ensure it won't cause the kernel crash.

The function is crap no matter whether its removed later or not. And
it breaks bisectability.

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/