Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

[Joe Perches]

On Tue, 2015-05-12 at 07:52 -0700, Joe Perches wrote:
> On Tue, 2015-05-12 at 16:04 +0200, Rasmus Villemoes wrote:
> > On Tue, Feb 10 2015, Kashyap Desai <kashyap.desai@xxxxxxxxxxxxx> wrote:
> > 
> > > Acked-by: Kashyap Desai <kashyap.desai@xxxxxxxxxxxxx>
> > >
> > >> -----Original Message-----
> > >> From: Rasmus Villemoes [mailto:linux@xxxxxxxxxxxxxxxxxx]
> > >> Sent: Friday, February 06, 2015 8:04 PM
> > >> To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. Bottomley
> > >> Cc: Rasmus Villemoes; megaraidlinux.pdl@xxxxxxxxxxxxx; linux-
> > >> scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > >> Subject: [PATCH] scsi: megaraid_sas: Prevent future %p disaster
> > >>
> > >> There is currently no %po format extension, so currently the letters
> > > "on" are
> > >> simply skipped and the pointer is printed as expected (while missing the
> > > word
> > >> on). However, it is probably only a matter of time before someone comes
> > > up
> > >> with a %po extension, at which point this is likely to fail
> > > spectacularly.
> > >>
> > >> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> > 
> > Any chance either this minimal fix or Joe's more thorough cleanup could
> > get applied? There's still no %po extension, but there's certainly a lot
> > of proposals for more %p extensions flying around LKML, so I still think
> > the "only a matter of time" holds.
> 
> There's also this one with %pM6:

And another with %ptail
---
 arch/s390/kernel/perf_cpum_sf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c
index e6a1578..c0a4b87 100644
--- a/arch/s390/kernel/perf_cpum_sf.c
+++ b/arch/s390/kernel/perf_cpum_sf.c
@@ -205,7 +205,7 @@ static int realloc_sampling_buffer(struct sf_buffer *sfb,
 	 */
 	if (sfb->sdbt != get_next_sdbt(tail)) {
 		debug_sprintf_event(sfdbg, 3, "realloc_sampling_buffer: "
-				    "sampling buffer is not linked: origin=%p"
+				    "sampling buffer is not linked: origin=%p "
 				    "tail=%p\n",
 				    (void *) sfb->sdbt, (void *) tail);
 		return -EINVAL;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/