Re: [PATCH 0/2]: Make FSL EHCI drv as separate module

[Alan Stern]

On Tue, 12 May 2015, Ramneek Mehresh wrote:

> This patch set makes fsl ehci driver as a separate module 
> from existing ehci-hcd driver. For this, following is done:
> 	- make ehci-fsl.c as a seperate entity by compiling
> 	  it separately
> 	- make use of module_init()/module_exit(), and 
> 	  makeing ehci-fsl.c as tristate
> 	- using overrides structure to override "reset" and
> 	  "extra_priv_size"
> 
> Ramneek Mehresh (2):
>   drivers:usb:fsl:Make fsl ehci drv an independent module
>   drivers:usb:fsl: Use overrides structure for fsl hc driver

These need to be combined into a single patch.  As it stands now, if 
someone applies patch 1/2 but not 2/2 (which could happen in the middle 
of a bisection, for example), the driver will fail to build.


+#define DRIVER_DESC "Fsl EHCI driver"

...

-static const struct hc_driver fsl_ehci_hc_driver = {
-       .description = hcd_name,
-       .product_desc = "Freescale On-Chip EHCI Host Controller",

How is anybody supposed to know what "Fsl" means?  Your new DRIVER_DESC 
string should be more like the old .product_desc string.

-/**
- * usb_hcd_fsl_probe - initialize FSL-based HCDs
+/*
+ * fsl_ehci_drv_probe - initialize FSL-based HCDs
  * @drvier: Driver to be used for this HCD
  * @pdev: USB Host Controller being probed
  * Context: !in_interrupt()
@@ -45,8 +54,7 @@
  * Allocates basic resources for this USB host controller.
  *
  */
-static int usb_hcd_fsl_probe(const struct hc_driver *driver,
-                            struct platform_device *pdev)
+static int fsl_ehci_drv_probe(struct platform_device *pdev)
 {

Since you eliminated the const struct hc_driver *driver parameter from 
this function, you should also eliminate the corresponding line from 
the kerneldoc above the function.  (Note that the line even misspells 
"driver"!)

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/