Re: [PATCH] net: deinline netif_tx_stop_all_queues(), remove WARN_ON in netif_tx_stop_queue()

From: Alexei Starovoitov
Date: Tue May 12 2015 - 12:00:30 EST

On Mon, May 11, 2015 at 09:17:53PM +0200, Denys Vlasenko wrote:
> These functions compile to 60 bytes of machine code each.
> With this .config:
> there are 617 calls of netif_tx_stop_queue()
> and 49 calls of netif_tx_stop_all_queues() in vmlinux.
> To fix this, remove WARN_ON in netif_tx_stop_queue()
> as suggested by davem, and deinline netif_tx_stop_all_queues().
> Change in code size is about 20k:
> text data bss dec hex filename
> 82426986 22255416 20627456 125309858 77813a2 vmlinux.before
> 82406248 22255416 20627456 125289120 777c2a0 vmlinux

nice code shrink. Looks good to me.

Acked-by: Alexei Starovoitov <ast@xxxxxxxxxxxx>

btw, in the future please say [PATCH net-next] as part of subject
to make it clear what tree this patch is going to.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at