Re: [PATCH 1/5] selftests: Add futex functional tests

[Darren Hart]

On 5/12/15, 3:02 AM, "Cyril Hrubis" <chrubis@xxxxxxx> wrote:

>Hi!
>> I'm happy to do that, but I would like to make sure I'm doing the right
>> thing.
>
>The right thing here is to add -pthread to CFLAGS which sets both flags
>for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the
CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I
understand we have a number of gcc-isms in our build - but do we want to
add more?

I'm also struggling to find any kind of prescribed documentation on this
beyond the short blurb in the gcc man page which describes what this
option does, but not when to use it. I'll need something concrete to
justify changes to testcase Makefiles to Shuah.

Unfortunately, all these options are functional for me, while some are not
for Shuah, so I'm currently having to rely on documentation which seems
pretty sparse.

-- 
Darren Hart
Intel Open Source Technology Center



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/