Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers
From: Doug Ledford
Date: Tue May 12 2015 - 16:09:35 EST
On Tue, 2015-05-12 at 12:09 -0600, Jason Gunthorpe wrote:
> On Mon, May 11, 2015 at 08:27:00PM -0400, Doug Ledford wrote:
> > On Mon, 2015-05-11 at 19:49 -0400, ira.weiny wrote:
> > > I have run with this series and the only issue I have found is not with this
> > > patch set directly.
> > >
> > > This patch:
> > >
> > > > IB/Verbs: Use management helper rdma_cap_ib_mad()
> > >
> > > causes an error when you actually use the port passed from the ib_umad module.
> > > I have a patch to fix that which I found while trying to build on this series
> > > for the use of a bit mask.
> > >
> > > Doug, I don't know what you would like to do for this fix. I am submitting it
> > > shortly with a new version of the core capability bit patches. If you want to
> > > just add it after this series or force Michael to respin with the fix?
> > As I recall, there was a comment from Or requesting to squash some of
> > the individual patches down, but I no longer have that email in my Inbox
> > to double check. And it seemed like there was one other review comment
> > not yet addressed. Do I have that right Michael? And if so, are you
> > working on a v9?
> I had asked for better kdocs for the new helpers so new people can
> understand when and where to use them.
> I've not looked at the series at all for the past few postings.
Michael, please work up an incremental patch to address the kdocs issue.
I've picked up the v8 patchset, and there is no need to respin it, but I
would like to have that kdoc patch before the 4.2 merge window opens.
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: 0E572FDD
Description: This is a digitally signed message part