Re: [PATCH v5] net: phy: micrel: Fix regression in kszphy_probe

From: David Miller
Date: Tue May 12 2015 - 23:19:17 EST

From: Niklas Cassel <niklas.cassel@xxxxxxxx>
Date: Tue, 12 May 2015 09:43:14 +0200

> Don't do clock-mode-select if clk == NULL,
> since when building without CONFIG_HAVE_CLK,
> clk_get returns NULL and clk_get_rate returns 0.
> Doing clock-mode-select in this cause causes kszphy_probe to
> return -EINVAL and thus prevents the device from being probed.
> The original code (before regression) would return 0
> when building without CONFIG_HAVE_CLK.
> Cc: stable <stable@xxxxxxxxxxxxxxx> # 3.18+
> Fixes: 1fadee0c3645 ("net/phy: micrel: Add clock support for
> KSZ8021/KSZ8031")
> Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> Reviewed-by: Johan Hovold <johan@xxxxxxxxxx>
> Signed-off-by: Niklas Cassel <niklass@xxxxxxxx>

Applied, thank you.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at