Re: [PATCH v11 04/10] iommu/vt-d: functions to copy data from old mem

From: Li, ZhenHua
Date: Wed May 13 2015 - 05:14:16 EST


Hi Baoquan,
I am using a list here to store all the mapped addresses, and unmap them out of iounmap.

About the reason, please check the old mails. I cannot remember the detailed reasons.

Thanks
Zhenhua

On 05/13/2015 05:00 PM, Baoquan He wrote:
On 05/11/15 at 05:52pm, Li, Zhen-Hua wrote:
Add some functions to copy the data from old kernel.
These functions are used to copy context tables and page tables.

To avoid calling iounmap between spin_lock_irqsave and spin_unlock_irqrestore,
use a link here, store the pointers , and then use iounmap to free them in
another place.

Hi Zhenhua,

I remember you mentioned iounmap will cause error inside
spin_lock_irqsave. Do you know why it happened now? And could you also
describe why avoid calling iounmap between
spin_lock_irqsave/unlock_irqsave is needed here and what's the status
now?

I think other reviewer may want to know it too.

Thanks
Baoquan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/