RE: [PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver

[Opensource [Steve Twiss]]

On 13 May 2015 11:35 Lee Jones wrote:

> > From: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
> >
> > Add MFD support for the DA9063 OnKey driver
> >
> > The function da9063_clear_fault_log() is added to mitigate the case of a
> > hardware power-cut after a long-long OnKey press. Although there is no
> > software intervention in this case (by definition) such a shutdown would
> > cause persistent information within the DA9063 FAULT_LOG that would be
> > available during the next device restart.
> >
> > Clearance of this persistent register must be completed after such a
> > hardware power-cut operation has happened so that the FAULT_LOG does not
> > continue with previous values. The clearance function has been added here
> > in the kernel driver because wiping the fault-log cannot be counted on
> > outside the Linux kernel.
> >
> >
> > Signed-off-by: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
> >

[...]

> >  drivers/mfd/da9063-core.c        | 54
> ++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/da9063/pdata.h |  1 +
> >  2 files changed, 55 insertions(+)
> 
> I'll wait to see what Dmitry has to say before applying, but for my
> own reference:

Understood.
Thank you.

> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

Thanks for this Ack.
And for [PATCH V4 2/3] devicetree: Add bindings for DA9063 OnKey

Regards,
Steve