Re: [patch v2] checkpatch: complain about GW-BASIC style label names

From: Al Viro
Date: Wed May 13 2015 - 10:12:43 EST

On Wed, May 13, 2015 at 03:37:12PM +0300, Dan Carpenter wrote:
> GW-BASIC style label names are annoying so we can warn about that in
> checkpatch. The warnings look like:
> WARNING: 'fail2' isn't informative - prefer descriptive label names
> #267: FILE: ./sound/ppc/beep.c:267:
> + fail2: snd_ctl_remove(chip->card, beep_ctl);
> This generates slightly under 2000 new warnings. None of them are
> false positives.

And all of them are complete garbage. Please, stop forcing your personal
preferences upon the rest of us.

Any "fixes" of that sort in fs/*.c will be passed straight to /dev/null.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at